[bitbake-devel] [PATCH 4/5] toaster/orm/management/commands/lsupdates.py: Use new layerindex module

Paul Eggleton paul.eggleton at linux.intel.com
Thu Aug 3 22:15:02 UTC 2017


On Thursday, 3 August 2017 8:18:03 PM CEST Mark Hatle wrote:
> On 8/3/17 1:06 PM, Paul Eggleton wrote:
> > On Friday, 28 July 2017 5:37:21 PM CEST Mark Hatle wrote:
> >> Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
> > 
> > Missing a commit message - and you wrote the book on proper commit 
> > messages :p
> 
> In this case, what is wrong with the message.  The change doesn't do
> anything but use the new layer index module.  Functionality remains the 
> same.

Wouldn't you at minimum want to state exactly that last bit then? That isn't 
clear without carefully looking through the patch.

Same for the other commit, except there what is displayed by bitbake-layers 
layerindex-fetch has changed a little bit.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the bitbake-devel mailing list