[bitbake-devel] [PATCH] cooker.py: allow dangling bbappends if explicitly whitelisted

Christopher Larson kergoth at gmail.com
Thu May 25 15:50:07 UTC 2017


On Mon, May 22, 2017 at 3:50 AM, Patrick Ohly <patrick.ohly at intel.com>
wrote:

> Having a .bbappend without corresponding .bb file triggers an error or
> at least warning, depending on the global BB_DANGLINGAPPENDS_WARNONLY.
>
> Some layers (for example, meta-freescale) avoid that message by only
> adding .bbappends to the BBFILES when the layers they apply to are
> present. Others (like intel-iot-refkit) avoid such .bbappends by
> falling back to global assignments with _pn-<recipe> as override. Both
> is complicated.
>
> Now the warning code checks BBAPPENDS_DANGLING_WHITELIST and ignores
> all bbappends which match a file pattern in that list. This is an
> easier way to have bbappends which may or may not apply to an
> existing recipe.
>

IMHO this makes it too easy to miss legitimate problems. By adding them
only when the layers are present, you ensure that if that layer removes the
recipe you’re appending, you’ll immediately know it. This hides such actual
problems by suppressing for all optional appends across the board.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20170525/61457599/attachment-0002.html>


More information about the bitbake-devel mailing list