[bitbake-devel] [PATCH] cooker.py: allow dangling bbappends if explicitly whitelisted

[Mark Hatle]

On 5/25/17 10:50 AM, Christopher Larson wrote:
> 
> On Mon, May 22, 2017 at 3:50 AM, Patrick Ohly <patrick.ohly at intel.com
> <mailto:patrick.ohly at intel.com>> wrote:
> 
>     Having a .bbappend without corresponding .bb file triggers an error or
>     at least warning, depending on the global BB_DANGLINGAPPENDS_WARNONLY.
> 
>     Some layers (for example, meta-freescale) avoid that message by only
>     adding .bbappends to the BBFILES when the layers they apply to are
>     present. Others (like intel-iot-refkit) avoid such .bbappends by
>     falling back to global assignments with _pn-<recipe> as override. Both
>     is complicated.
> 
>     Now the warning code checks BBAPPENDS_DANGLING_WHITELIST and ignores
>     all bbappends which match a file pattern in that list. This is an
>     easier way to have bbappends which may or may not apply to an
>     existing recipe.
> 
> 
> IMHO this makes it too easy to miss legitimate problems. By adding them only
> when the layers are present, you ensure that if that layer removes the recipe
> you’re appending, you’ll immediately know it. This hides such actual problems by
> suppressing for all optional appends across the board.

I agree.  I prefer the Freescale approach.  Only add the bbappend when the thing
it should be appending is present.

Avoids the problem of 'hidden' errors (things missing), but does cause an issue
with more combinations needing to be tested, but at least this is more explicit.

--Mark