[OE-core] [CONSOLIDATED PULL 012/113] base.bbclass: Allow buildstats to be optionally supplied

[Saul Wold]

On 01/03/2012 10:06 AM, Mark Hatle wrote:
> On 1/3/12 6:14 AM, Phil Blundell wrote:
>> On Mon, 2012-01-02 at 22:18 -0800, Saul Wold wrote:
>>> From: Mark Hatle<mark.hatle at windriver.com>
>>>
>>> Buildstats should be allowed to be optionally enabled. It's
>>> recommended that it be enabled via the USER_CLASSES setting.
>>>
>>> Alternatively it could be enabled via the INHERIT_DISTRO or
>>> similar mechanism.
>>>
>>> Signed-off-by: Mark Hatle<mark.hatle at windriver.com>
>>
>> I don't think the short summary of this patch gives a very clear
>> indication of what it's doing. The terminology "optionally supplied"
>> makes it sound as though you're talking about some sort of add-on data
>> file which can be enabled. Whereas, what the patch seems actually to be
>> doing is removing the unconditional inherit of buildstats (i.e. turning
>> it off for almost everyone who has it on today) and adding a suggestion
>> in local.conf.sample as to how it might be turned on again.
>
> Perhaps enabled is a better word then "supplied" in this case?
>
> I didn't comment that it was removing the unconditional inherit as I
> thought that was obvious..
>
> Saul -- can you change the short summary or should I resend it?
>
Already merged by the time this email came in!  Sorry.

Sau!

>> (That said, I do think the intent of this patch is a good one; it's been
>> a long-standing source of irritation to me that disabling buildstats is
>> so awkward at present.)
>
> This was causing a problem for me as well, thus the solution. Seemed
> simply enough and beneficial.
>
> --Mark
>
>> p.
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>