[OE-core] [RFC PATCH 1/1][v2] self-hosted-image: generate the .hdddirect and .vmdk image files
Cui, Dexuan
dexuan.cui at intel.com
Thu Jan 19 01:30:08 UTC 2012
Saul Wold wrote on 2012-01-19:
>> + if [ "${NOVMDK}" != "1" ] ; then
> Why make this a "double negative", Why not have a CREATE_VMDK check?
>
>> + ${STAGING_BINDIR_NATIVE}/qemu-img convert -O vmdk \
>> + ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.hdddirect \
>> + ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.vmdk
>> + fi
>> }
Hi Saul,
I thought it's better to create .vmdk by default.
So do you think this is better?
if [ "${CREATE_VMDK}" == "1" ] ; then
#create the .vmdk image.
fi
In this way we don't create .vmdk by default and I'll define
CREATE_VMDK = "1"
in self-hosted-image.bb to generate the .vmdk.
Thanks,
-- Dexuan
More information about the Openembedded-core
mailing list