[OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

Alexander Kanavin alexander.kanavin at linux.intel.com
Mon Dec 21 11:39:15 UTC 2015


On 12/21/2015 01:27 PM, Otavio Salvador wrote:

> Commit logs are suppose to have the information useful to understand
> the reason of the change. Latest hides all behind it and does not
> communicate anything. I don't think expect people to read the code to
> know you bumped (and to which) revision is right.

Having the exact upstream commit id - a bunch of random numbers and 
letters - in the commit message does not make the commit message any 
more useful, readable, or searchable. You can't even click on that id to 
open a gitweb webpage with the upstream patch (having that kind of link 
*would* be useful though).

The change to the recipe is short, and no one should be overwhelmed by 
looking at it if they need the commit id.

Alex



More information about the Openembedded-core mailing list