[OE-core] [PATCH] wic: use kB for the partitions size

Alexandre Belloni alexandre.belloni at free-electrons.com
Wed Feb 4 10:53:06 UTC 2015


On 04/02/2015 at 11:29:23 +0100, Maciej Borzecki wrote :
> > +    mapping = {"opt": opt, "value": value}
> > +    if (not value[0:len(value)-1].isdigit()):
> 
> You might want to replace value[0:len(value)-1] with value[:-1] here and
> in int(...) below.
> 

Ah sure, I was looking for a better way to do that, thanks!

> Other than that, the patch looks ok for me. I've built a couple of
> images with different sizes (with and without suffix), all worked fine.
> 
> Tested-by: Maciej Borzecki <maciej.borzecki at open-rnd.pl>
> 
-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the Openembedded-core mailing list