[OE-core] [PATCH V2 3/3] systemd: split modules into packages

[Bottazzini, Bruno]

On Ter, 2015-05-05 at 17:38 -0300, Leandro Dorileo wrote:
> On 05/05/2015 05:01 PM, Anders Darander wrote:
> > * Bruno Bottazzini <bruno.bottazzini at intel.com> [150504 23:43]:
> >
> >> diff --git a/meta/recipes-core/systemd/systemd_219.bb b/meta/recipes-core/systemd/systemd_219.bb
> >> index b4bff18..2da74dc 100644
> >> --- a/meta/recipes-core/systemd/systemd_219.bb
> >> +++ b/meta/recipes-core/systemd/systemd_219.bb
> >> @@ -60,9 +60,89 @@ LDFLAGS_append_libc-uclibc = " -lrt"
> >>   GTKDOC_DOCDIR = "${S}/docs/"
> >
> >>   PACKAGECONFIG ??= "xz ldconfig \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'gcrypt', 'gcrypt', "", d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'kmod', 'kmod', "", d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'blkid', 'blkid', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'efi', 'efi', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'lz4', 'lz4', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'libidn', 'libidn', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
> >>                      ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
> >> -                   ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)}"
> >> -
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'glib', 'glib', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'blkid', 'blkid', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'efi', 'efi', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'kmod', 'kmod', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'polkit', 'polkit', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'smack', 'smack', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'ima', 'ima', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'apparmor', 'apparmor', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'seccomp', 'seccomp', '', d)} \
> >> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'qrencode', 'qrencode', '', d)} \
> >
> > NAK.
> >
> > I like the split of systemd into smaller packages, but NAK for this
> > version. We're not going to add all this to DISTRO_FEATURES...
> >
> > Add all the PACKAGCONFIG options, but enable only those that either were
> > enabled before, or where we have a real DISTRO_FEATURE to check for.
> > Dpn't add a new DISTRO_FEATURE for every PACKAGECONFIG.
> >
> 
> Just to have it documented here via ML, Anders and I talked on IRC
> and we agreed to add PACKAGECONFIG[feature] definitions for both
> features and have the "current features" enabled by default without
> using  DISTRO_FEATURES - since we don't want to add these
> DISTRO_FEATURES.
> 
> For distros wanting to use the "new packages/features" we do so by
> adding PACKAGECONFIG_pn-systemd... on the distro side.
> 
> Regards...
> 
> --
> Dorileo

I agree with the changes as soon as everyone has reviewed I will send a
new one version.

Best Regards,

Bruno Bottazzini