[OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain()

[Andre McCurdy]

On Tue, May 12, 2015 at 1:40 AM, Paul Eggleton
<paul.eggleton at linux.intel.com> wrote:
> Hi Andre,
>
> On Monday 11 May 2015 17:34:45 Andre McCurdy wrote:
>> On Wed, Feb 25, 2015 at 7:15 AM, Cristian Iorga
>>
>> <cristian.iorga at intel.com> wrote:
>> > oe.utils.both_contain() just does a find() on the value
>> > rather than splitting the value and then looking in the
>> > list of split items. The result is that if you add a
>> > feature to MACHINE_FEATURES that itself has a substring
>> > that matches one of the values looked for when building
>> > COMBINED_FEATURES, you end up with an incomprehensible
>> > error (here with "ext2i" in MACHINE_FEATURES):
>> >
>> > ERROR: Nothing RPROVIDES 'packagegroup-base-ext2'
>> > (but /home/balister/src/oe-core/oe-core/meta/recipes-core/
>> > /packagegroups/packagegroup-base.bb RDEPENDS on or otherwise requires it)
>>
>> This change seems to break COMBINED_FEATURES.
>>
>> $ bitbake -e packagegroup-base | grep '^COMBINED_FEATURES='
>>
>> dizzy:
>>   COMBINED_FEATURES="alsa         "
>>
>> fido:
>>   COMBINED_FEATURES="set(['alsa'])         "
>
> Yes it did, unfortunately. There was a follow-up fix in master:
>
>   http://cgit.openembedded.org/openembedded-core/commit/?id=c4ca9dbd4191fcff08e75035e3d276490ed80b05
>
> This is included in Joshua's pending backport changeset for fido.

I see it now. Thanks Paul.

>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre