[OE-core] [PATCH] gnutls: remove --with-libz-prefix configure option

[Andre McCurdy]

On Mon, May 25, 2015 at 11:32 AM, Aníbal Limón
<anibal.limon at linux.intel.com> wrote:
> Hi Andre,

Hi Aníbal,

> This patch broke gnutls build on multilib,
>
> ERROR: QA Issue: gnutls: The compile log indicates that host include and/or
> library paths were used.
>          Please check the log
> '/home/alimon/repos/poky/build-x86-64-multilib/tmp/work/core2-64-poky-linux/gnutls/3.3.14-r0/temp/log.do_compile'
> for more information. [compile-host-path]
> ERROR: QA run found fatal errors. Please consider fixing them.
> ERROR: Function failed: do_package_qa
> ERROR: Logfile of failure stored in:
> /home/alimon/repos/poky/build-x86-64-multilib/tmp/work/core2-64-poky-linux/gnutls/3.3.14-r0/temp/log.do_package_qa.25738
> ERROR: Task 2411
> (/home/alimon/repos/poky/meta/recipes-support/gnutls/gnutls_3.3.14.bb,
> do_package_qa) failed with exit code '1

I'm not able to reproduce your error, but based on some googling it
seems that issues cross compiling gnutls are not uncommon. Buildroot
added the --with-libz-prefix configure option specifically to fix
issues with configure finding the host's libz [1]. Chromium has a more
complete fix, which patches configure.ac to find libz using
PKG_CHECK_MODULES instead of AC_LIB_HAVE_LINKFLAGS [2].

Since the original issue (absolute paths in gnutls.pc Libs.private) is
fairly benign, I think the best solution right now is to revert back
to using the --with-libz-prefix configure option in OE.

 [1] http://lists.busybox.net/pipermail/buildroot/2014-February/088307.html
 [2] https://chromium-review.googlesource.com/#/c/271661/2/net-libs/gnutls/files/gnutls-2.12.23-cross-compile.patch


> Kind regards,
>     alimon
>
>
> On 21/05/15 19:11, Andre McCurdy wrote:
>>
>> The default search path in sysroot is sufficient to find zlib, so the
>> --with-libz-prefix configure option seems to be unnecessary.
>>
>> For target builds, relying on sysroot also prevents an absolute path
>> from being hardcoded in the gnutls.pc pkg-config file.
>>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> ---
>>   meta/recipes-support/gnutls/gnutls.inc | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/gnutls/gnutls.inc
>> b/meta/recipes-support/gnutls/gnutls.inc
>> index 45fb529..87f275a 100644
>> --- a/meta/recipes-support/gnutls/gnutls.inc
>> +++ b/meta/recipes-support/gnutls/gnutls.inc
>> @@ -23,7 +23,6 @@ EXTRA_OECONF="--disable-rpath \
>>                 --with-included-libtasn1 \
>>                 --enable-local-libopts \
>>                 --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
>> -              --with-libz-prefix=${STAGING_DIR_HOST}${prefix} \
>>                 --disable-guile \
>>                 --disable-crywrap \
>>                 --without-p11-kit \
>
>