[OE-core] [PATCH 1/1] logrotate: do not move binary logrotate to /usr/bin

[Christopher Larson]

On Mon, Nov 2, 2015 at 1:33 AM, Hongxu Jia <hongxu.jia at windriver.com> wrote:

> In oe-core commit a46d3646a3e1781be4423b508ea63996b3cfca8a
> ...
> Author: Fahad Usman <fahad_usman at mentor.com>
> Date:   Tue Aug 26 13:16:48 2014 +0500
>
>     logrotate: obey our flags
>
>     Needed to quiet GNU_HASH warnings, and some minor fixes.
> ...
> it explicitly move logrotate to /usr/bin without any reason,
> which is against the original Linux location /usr/sbin.
>
> So partly revert the above commit which let logrotate be
> kept in the original place /usr/sbin.
>
> Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
> ---
>  meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> index 7d0a159..5f1a601 100644
> --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> @@ -53,7 +53,7 @@ do_compile_prepend() {
>  }
>
>  do_install(){
> -    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
> BINDIR=${bindir}
> +    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
>      mkdir -p ${D}${sysconfdir}/logrotate.d
>      mkdir -p ${D}${sysconfdir}/cron.daily
>      mkdir -p ${D}${localstatedir}/lib
>

This just makes it not obey our target paths again, using its hardcoded
destination. Why not pass BINDIR=${sbindir} instead?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20151116/dd617d20/attachment-0002.html>