[OE-core] [PATCH] Fix recursive mode -st on BUILDDIR setup
Alex Franco
alejandro.franco at linux.intel.com
Thu Sep 3 20:01:20 UTC 2015
Hello Martin, so the error you are seeing is related to the chmodding
being done in sanity.bbclass, not the chmodding taking place in
oe-setup-builddir. I am adding a catch and a warning for that, as I
reproduce your setup so I can also reproduce the OSError.
Alex
On 09/02/2015 07:57 PM, Martin Jansa wrote:
> Warning informing that chmod failed is better than fatal error
> preventing me to build anything in that setup with tmpfs.
>
> On Wed, Sep 2, 2015 at 11:27 PM, Alex Franco
> <alejandro.franco at linux.intel.com
> <mailto:alejandro.franco at linux.intel.com>> wrote:
>
> Checking may be the better approach, as warning here would do
> little more than what the current failure does (informing that
> chmod failed)
>
> Alex Franco
>
>
> On 09/02/2015 01:25 PM, Martin Jansa wrote:
>
> On Wed, Sep 02, 2015 at 06:51:23PM +0100, Richard Purdie wrote:
>
> On Wed, 2015-09-02 at 11:36 -0500, Alex Franco wrote:
>
> Removing recursive option from chmod -st on BUILDDIR
> as it would
> take very long on existing build directories
>
> [YOCTO 7669]
>
> Signed-off-by: Alex Franco
> <alejandro.franco at linux.intel.com
> <mailto:alejandro.franco at linux.intel.com>>
> ---
> scripts/oe-setup-builddir | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/oe-setup-builddir
> b/scripts/oe-setup-builddir
> index f5b7e4e..44c7dcc 100755
> --- a/scripts/oe-setup-builddir
> +++ b/scripts/oe-setup-builddir
> @@ -24,7 +24,7 @@ if [ -z "$BUILDDIR" ]; then
> fi
> mkdir -p "$BUILDDIR/conf"
> -chmod -R -st "$BUILDDIR"
> +chmod -st "$BUILDDIR"
>
> I think you did this so that conf/ gets the right
> permissions too.
> Perhaps the best approach is:
>
> +chmod -st "$BUILDDIR" $BUILDDIR/conf"
>
> Can we add "|| bbwarn foo"
>
> for cases when it doesn't work for whatever reason or check the
> permissions of these 2 dirs before calling chmod?
>
> ?
>
> Cheers,
>
> Richard
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> <mailto:Openembedded-core at lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150903/d81608e0/attachment-0002.html>
More information about the Openembedded-core
mailing list