[OE-core] can "IMAGE_INSTALL ?= ..." not be written in a more obvious way?

Robert P. J. Day rpjday at crashcourse.ca
Sat Dec 10 11:40:27 UTC 2016


  i've nattered about this before but not sure i ever got an answer --
here's the last bit of core-image.bbclass:

  CORE_IMAGE_BASE_INSTALL = '\
    packagegroup-core-boot \
    packagegroup-base-extended \
    \
    ${CORE_IMAGE_EXTRA_INSTALL} \
    '

  CORE_IMAGE_EXTRA_INSTALL ?= ""

  IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}"

the first time i saw that (long ago), it took me a few looks to figure
out what was happening. can this not be written in a more obvious way:

  CORE_IMAGE_BASE_INSTALL = '\
    packagegroup-core-boot \
    packagegroup-base-extended \
    '

  CORE_IMAGE_EXTRA_INSTALL ?= ""

  IMAGE_INSTALL ?= " \
    ${CORE_IMAGE_BASE_INSTALL} \
    ${CORE_IMAGE_EXTRA_INSTALL} \
    "

is that not equivalent, or am i missing something? it's certainly
clearer as to what's happening if people are perusing the code.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================




More information about the Openembedded-core mailing list