[OE-core] [PATCH v2 3/3] selftest/wic: Add tests for --exclude-dir option.
Ed Bartosh
ed.bartosh at linux.intel.com
Mon Dec 19 11:57:12 UTC 2016
On Mon, Dec 19, 2016 at 10:09:22AM +0100, Kristian Amlie wrote:
>
> >> + def test_exclude_path(self):
> >> + """Test --exclude-path wks option."""
> >> +
> >> + # For using 'e2ls'.
> >> + old_path = os.environ['PATH']
> >> + os.environ['PATH'] = get_bb_var('PATH', 'core-image-minimal')
> >> +
> >> + wks_file = 'temp.wks'
> >> + ks = open(wks_file, 'w')
> >
> > I'd use more pythonic 'with open(wks_file, 'w') as wks:' here.
>
> Done for all three blocks!
>
Thank you!
The patchset looks good to me.
--
Regards,
Ed
More information about the Openembedded-core
mailing list