[OE-core] [OE-Core][Patch 01/13] arch-mips: Add MACHINEOVERRIDES variables to reduce duplication

[Andre McCurdy]

On Mon, Nov 7, 2016 at 9:30 AM, Khem Raj <raj.khem at gmail.com> wrote:
>
> On 11/7/16 7:01 AM, Zubair Lutfullah Kakakhel wrote:
>> In some cases, each MIPS variant in a recipe requires a duplicate
>> line. Even if the passed flag is the same.
>>
>> Add global MACHINEOVERRIDES variables for the following
>>  * mipsarch           : All MIPS
>>  * mipsarchr6         : All MIPS R6
>>  * mipsarcho32{el}    : All MIPS o32
>>  * mipsarchn32{el}    : All MIPS n32
>>  * mipsarchn64{el}    : All MIPS n64
>>
>> This is intended to reduce duplications in recipes
>>
>> [YOCTO #10404]
>>
>> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel at imgtec.com>
>> ---
>>  meta/conf/machine/include/mips/arch-mips.inc | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/meta/conf/machine/include/mips/arch-mips.inc b/meta/conf/machine/include/mips/arch-mips.inc
>> index 6069ca1..5b42841 100644
>> --- a/meta/conf/machine/include/mips/arch-mips.inc
>> +++ b/meta/conf/machine/include/mips/arch-mips.inc
>> @@ -50,6 +50,13 @@ MIPSPKGSFX_32R6 = "${@bb.utils.contains('TUNE_FEATURES', 'mipsisa32r6', 'isa32',
>>  TUNE_ARCH = "mips${MIPSPKGSFX_32R6}${MIPSPKGSFX_64R6}${MIPSPKGSFX_BYTE}${MIPSPKGSFX_R6}${MIPSPKGSFX_ENDIAN}"
>>  TUNE_PKGARCH = "${MIPSPKGSFX_VARIANT_tune-${DEFAULTTUNE}}${MIPSPKGSFX_FPU}${MIPSPKGSFX_ABI}"
>>
>> +# Various Global Machine Overrides
>> +MACHINEOVERRIDES =. "mipsarch:"
>> +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'r6', 'mipsarchr6:', '' ,d)}"
>> +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'n32', 'mipsarchn32${MIPSPKGSFX_ENDIAN}:', '' ,d)}"
>> +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'o32', 'mipsarcho32${MIPSPKGSFX_ENDIAN}:', '' ,d)}"
>> +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'n64', 'mipsarch64${MIPSPKGSFX_ENDIAN}:', '' ,d)}"
>
> how about mips16 ?

We explicitly removed _thumb as an over-ride for ARM, so adding the
equivalent for MIPS would be odd, unless you see a clear need for it?

  http://git.openembedded.org/openembedded-core/commit/?id=351443d71eb246a946b41f12b54d57b36fe1574e

>> +
>>  # Base tunes
>>  AVAILTUNES += "mips mips64-n32 mips64 mipsel mips64el-n32 mips64el mips-nf mips64-nf-n32 mips64-nf mipsel-nf mips64el-nf-n32 mips64el-nf"
>>  TUNE_FEATURES_tune-mips = "o32 bigendian fpu-hard"
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core