[OE-core] [PATCH 4/4] sanity.bbclass: fix check_connectivity() for BB_NO_NETWORK = "0"

[Christopher Larson]

On Mon, Nov 14, 2016 at 7:34 AM, Robert Yang <liezhi.yang at windriver.com>
wrote:

> The old code:
> network_enabled = not d.getVar('BB_NO_NETWORK', True)
>
> It is True only when BB_NO_NETWORK is not set (None),
> but BB_NO_NETWORK = "0" should also be True while "1" means no network,
> "0" means need network in a normal case.
>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
>  meta/classes/sanity.bbclass | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 7e383f9..c5e3809 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -363,15 +363,19 @@ def check_connectivity(d):
>      test_uris = (d.getVar('CONNECTIVITY_CHECK_URIS', True) or "").split()
>      retval = ""
>
> +    bbn = d.getVar('BB_NO_NETWORK', True)
> +    if bbn not in (None, '0', '1'):
> +        return 'BB_NO_NETWORK should be "0" or "1", but it is "%s"' % bbn
>

Does this mirror the same logic used in bitbake? What’s the behavior if
it’s set, but to the empty string?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161114/55dd5587/attachment-0002.html>