[OE-core] [PATCH] added recipe for libdbus-c++
thilo.cestonaro at ts.fujitsu.com
thilo.cestonaro at ts.fujitsu.com
Tue Nov 15 15:27:05 UTC 2016
Am Dienstag, den 15.11.2016, 14:23 +0000 schrieb Burton, Ross:
>
> On 15 November 2016 at 13:46, Thilo Cestonaro <thilo.cestonaro at ts.fujitsu.com> wrote:
> > Signed-off-by: Thilo Cestonaro <thilo.cestonaro at ts.fujitsu.com>
> >
>
> As Alex said, please submit this to meta-oe as there's no strong rationale to keep it in oe-core, especially considering it's abandoned.
>
> The remove_CXX_FOR_BUILD-stuff patch can be trimmed to just modify configure.ac and tools/Makefile.am, the other files will be regenerated at do_configure and patching them can cause conflicts if
> upstream ever makes a new release.
>
> Also please explain clearly why that has to be removed in the patch header because usually we need to patch *in* the _FOR_BUILD macros: I was curious and ended up looking at the build to understand
> why. AFAICT it's because upstream if cross-compiling it refuses to build target tools and will only build host tools so the test suite can run, but disabling the tests and patching out CXX_FOR_BUILD
> we can build target tools. The downside is that we have no test suite, which is useful (see the ptest class).
Perhaps I will add ptest in another patch later. Will need to look into it.
Thanks for your comments!
>
> Thank you for being the first person in a long time to actually submit the recipe to the community!
>
> Ross
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3847 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161115/96a12988/attachment-0002.bin>
More information about the Openembedded-core
mailing list