[OE-core] [PATCH v2 1/3] module.bbclass: use Module.symvers for dependants
Denys Dmytriyenko
denis at denix.org
Thu Nov 17 18:47:30 UTC 2016
On Thu, Nov 17, 2016 at 10:22:18AM +0000, André Draszik wrote:
> Hi,
>
> On Wed, 2016-11-16 at 15:18 -0500, Denys Dmytriyenko wrote:
> > On Thu, Aug 18, 2016 at 08:56:24AM +0100, André Draszik wrote:
> > >
> > > @@ -24,6 +34,11 @@ module_do_install() {
> > > CC="${KERNEL_CC}" LD="${KERNEL_LD}" \
> > > O=${STAGING_KERNEL_BUILDDIR} \
> > > ${MODULES_INSTALL_TARGET}
> > > +
> > > + install -d -m0755 ${D}${includedir}/${BPN}
> > > + cp -a --no-preserve=ownership ${B}/Module.symvers
> > > ${D}${includedir}/${BPN}
> >
> > Hmm, why is Module.symvers expected to be in the root of ${B}? This seems
> > like
> > a very artificial assumption/requirement!
>
> [...]
>
> > I wonder if this should have been rolled into ${MODULES_INSTALL_TARGET}
> > step...
>
> What about adding a (lazy ?=) variable to be able to override the location
> of Module.symvers within ${B}, or alternatively using find to automatically
> detect it? I guess there could also be more than one in theory? Do you have
> something different in mind?
Yes, find will probably be too ambiguous, but I like the variable idea to
point to Module.symvers within ${B}!
For now I have a workaround to do an extra copy in do_install_prepend(), which
is not very elegant...
--
Denys
More information about the Openembedded-core
mailing list