[OE-core] [PATCH V2] scripts.send-pull-request: Avoid multiple chain headers

[Jose Lamego]

On 11/28/2016 03:34 PM, Patrick Ohly wrote:
> On Mon, 2016-11-28 at 14:28 -0600, Jose Lamego wrote:
>> Agree. Please provide feedback about below comments and I will submit a
>> v3 patch.
>>
>> On 11/28/2016 01:47 PM, Patrick Ohly wrote:
>>> On Mon, 2016-11-28 at 10:23 -0600, Jose Lamego wrote:
>> More than 1 "In-Reply-To" and "References" message headers are in
>> violation of rfc2822 [1] and may cause that some email-related
>> applications do not point to the appropriate root message in a
>> conversation/series.
> 
> Fixing that makes sense. Just add it as reason and the "why" part is
> covered.
> 
>>> And I don't understand why this proposed change has the described
>>> effect. Does changing the threading parameters change the output of "git
>>> send-email" and thus indirectly the mail headers of the following
>>> patches?
> 
> The "how" part still isn't clear to me. Perhaps I'm just dumb, but would
> you bear with me and explain a bit more how changing the sending of the
> cover letter affects sending of the patches?
> 
The script is duplicating the headers because it contains two individual
calls to git-send-email, one for the cover letter (when available) and
one for the rest of the series patches, both using the --no-chain-reply
option that includes a reference to the first message. What I'm doing
here is to include no reference to any root message at the first call,
then including a reference at the second call to the very first message
in the chain, which is either the cover letter or the patch #1.
This change is currently implemented/tested at [2] and complements a
change in patchwork [3] that handles messages including repeated headers
(created before this change gets implemented).

So the comment I would add to patch is:
    This change appends only one header pointing to very first patch
    in series or to cover letter if available by calling send-email
    with thread history option only once, instead of the original twice.

[2] patchwork-staging.openembedded.org
[3] https://lists.yoctoproject.org/pipermail/yocto/2016-November/033200.html
> As it isn't obvious, perhaps even add a comment to the script explaining
> it.
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161128/768e0f22/attachment-0002.sig>