[OE-core] [morty][PATCH 0/2] Resolve gdb-cross-canadian dependency on imp

George McCollister george.mccollister at gmail.com
Mon Feb 13 21:21:35 UTC 2017


On Thu, Feb 9, 2017 at 2:46 AM, Jussi Kukkonen <jussi.kukkonen at intel.com> wrote:
> On 8 February 2017 at 22:06, George McCollister
> <george.mccollister at gmail.com> wrote:
>>
>> Any chance we can get this applied to morty?
>
>
> You should add [morty] tag to subject and CC the maintainer
> (akuster808 at gmail.com) to improve chances of this happening. I'm sure Armin
> would also appreciate explicit confirmation that the patches apply to morty
> branch.

[morty] was in the subject but I didn't CC the maintainer. Now I know
who the maintainer is.

>
> Before that some review though (sorry I missed this in Dec) ... it looks
> like the "Add imp to importlib" commit only modified manifest.inc: this is a
> generated file and your changes will be overwritten next time someone runs
> the generator. You should modify
> scripts/contrib/python/generate-manifest-3.5.py and run that to generate the
> new manifest.inc file.

Yes, I messed that up. Someone else fixed it in master here:
http://git.openembedded.org/openembedded-core/commit/scripts/contrib/python/generate-manifest-3.5.py?id=bfe1d948ab034017622110c8365be7026e139fbf

>
> It would be nice if we did not store noth the source and the generated files
> in git but that's how it's currently setup...

I'll resend my two patches with the patch that fixes
generate-manifest-3.5.py for morty.

>
> Jussi



More information about the Openembedded-core mailing list