[OE-core] [PATCH] LSB 4.1: lsb_release script incompatible with busybox head and find

[Burton, Ross]

On 17 February 2017 at 16:50, Athanasios Oikonomou <athoik at gmail.com> wrote:

> +# Copyright (c) 2013 LG Electronics, Inc.
>

By submitting the patch this becomes MIT licensed, so this copyright
statement is pretty meaningless.


> +# Busybox implementation only supports head -1 option if
> ENABLE_INCLUDE_SUSv2
> +# or ENABLE_FEATURE_FANCY_HEAD configuration options are enabled. Also
> the -and
> +# option for find is only supported if ENABLE_DESKTOP configuration
> option is
> +# enabled. These configuration options are not enabled in build-webos,
> which is
> +# why this patch is needed.
>

Patch comments don't need to be on # lines.  Also this patch needs a
Signed-off-by and Upstream-Status in the header.  I can't see a reason why
the fixes don't go upstream, so please try submitting it there too.

--- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -2,7 +2,7 @@ SUMMARY = "LSB support for OpenEmbedded"
>  SECTION = "console/utils"
>  HOMEPAGE = "http://prdownloads.sourceforge.net/lsb"
>  LICENSE = "GPLv2+"
> -PR = "r2"
> +PR = "r3"
>

No need to bump PR, leave it at r2.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170217/d29bdddd/attachment-0002.html>