[OE-core] [PATCH] sanity.bbclass: fix AttributeError in mirror format checks
Patrick Ohly
patrick.ohly at intel.com
Mon Jul 3 09:56:39 UTC 2017
On Fri, 2017-06-30 at 14:24 +0300, Mikko Ylinen wrote:
> mirrors is a list after split() and results in:
>
> AttributeError: 'list' object has no attribute 'strip'
>
> when the 'mirror values are pairs' check fails.
>
> Signed-off-by: Mikko Ylinen <mikko.ylinen at linux.intel.com>
> ---
> meta/classes/sanity.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index e8064ac483..1f74026e13 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -839,7 +839,7 @@ def check_sanity_everybuild(status, d):
>
> # Split into pairs
> if len(mirrors) % 2 != 0:
> - bb.warn('Invalid mirror variable value for %s: %s, should contain paired members.' % (mirror_var, mirrors.strip()))
> + bb.warn('Invalid mirror variable value for %s: %s, should contain paired members.' % (mirror_var, str(mirrors).strip()))
.strip() is redundant here, because str(mirrors) will produce [...],
i.e. the string will never have leading or trailing spaces.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
More information about the Openembedded-core
mailing list