[OE-core] icecc in OE (Was: [PATCH] icecc.bbclass: prevent nativesdk builds depending on target specific KERNEL_CC)

[Tomas Novotny]

Hi Martin,

On Mon, 17 Jul 2017 17:35:46 +0200
Martin Jansa <martin.jansa at gmail.com> wrote:

> Hi Tomas,
> 
> last time we were more actively using 1.0.1-1 (with Ubuntu 12.04), but
> nowadays icecc.bbclass is mostly just historic relic for us, we still
> inherit it in our DISTROs (with 99.9999% builds running with ICECC_DISABLED
> = "1"), so that if someone enables icecc again he will get the same sstate
> signatures as our jenkins builds - to reuse already prepopulated
> sstate-cache.

so it looks like that there is only a few active users of icecc in oe...

> We also use own version of icecc-create-env, still the same as long time
> ago in:
> https://github.com/openwebos/meta-webos/tree/master/recipes-upstreamable/icecc-create-env

yes, I found it during my initial tests, but I was not sure if it used
(because of age).

Thanks for the information,

Tomas

> Regards,
> 
> On Mon, Jul 17, 2017 at 5:18 PM, Tomas Novotny <tomas at novotny.cz> wrote:
> 
> > Hi Martin,
> >
> > which version of icecc are you using?
> >
> > We were trying 1.1rc2, but we had to patch icecc-create-env script in oe.
> >
> > Tomas
> >
> > On Mon, 17 Jul 2017 16:04:50 +0200
> > Martin Jansa <martin.jansa at gmail.com> wrote:
> >  
> > > * without this we cause nativesdk-linux-libc-headers to depend
> > >   on target specific KERNEL_CC (through icecc_get_tool ->
> > >   icecc_is_kernel -> KERNEL_CC -> HOST_CC_KERNEL_ARCH ->
> > >   TARGET_CC_KERNEL_ARCH -> TUNE_FEATURES(thumb) as shown by
> > >   bitbake-diffsigs:
> > >
> > >   OE qemux86@ ~/build/oe-core $ ls /OE/build/oe-core/tmp-glibc/  
> > sstate-diff/1499859497/qemu*/*sdk*/*/*do_configure.sigdata*  
> > >   /OE/build/oe-core/tmp-glibc/sstate-diff/1499859497/  
> > qemuarm/x86_64-nativesdk-oesdk-linux/nativesdk-linux-
> > libc-headers/4.10-r0.do_configure.sigdata.3a9a423878d56524e0ee8e42eba1804f  
> > >   /OE/build/oe-core/tmp-glibc/sstate-diff/1499859497/  
> > qemux86/x86_64-nativesdk-oesdk-linux/nativesdk-linux-
> > libc-headers/4.10-r0.do_configure.sigdata.401071dbaa88903ece37d35a47965ff2  
> > >
> > >   OE qemux86@ ~/build/oe-core $ bitbake-diffsigs  
> > /OE/build/oe-core/tmp-glibc/sstate-diff/1499859497/qemu*/*
> > sdk*/*/*do_configure.sigdata*  
> > >   basehash changed from 39774238b66763c598153132e87a2c1a to  
> > aa2d66e770bf533e312536eb0a401c4c  
> > >   Variable TARGET_CC_KERNEL_ARCH value changed from  
> > '${@bb.utils.contains('TUNE_FEATURES', 'thumb',
> > '-mno-thumb-interwork-marm', '', d)} TUNE_FEATURES{thumb} = Set' to ''  
> > >
> > > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > > ---
> > >  meta/classes/icecc.bbclass | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> > > index 8a3308bdda..1cc1c4ddb0 100644
> > > --- a/meta/classes/icecc.bbclass
> > > +++ b/meta/classes/icecc.bbclass
> > > @@ -42,6 +42,7 @@ def icecc_dep_prepend(d):
> > >
> > >  DEPENDS_prepend += "${@icecc_dep_prepend(d)} "
> > >
> > > +get_cross_kernel_cc[vardepsexclude] += "KERNEL_CC"
> > >  def get_cross_kernel_cc(bb,d):
> > >      kernel_cc = d.getVar('KERNEL_CC', False)
> > >  
> >