[OE-core] [PATCH] ffmpeg: fix pkg-config utilization

[Nicolas Dechesne]

On Thu, Jul 20, 2017 at 1:56 PM, Nicolas Dechesne
<nicolas.dechesne at linaro.org> wrote:
>
> in config.log we can see:
> WARNING: aarch64-linaro-linux-pkg-config not found, library detection may fail.
>
> ffmpeg configure script is not looking for pkg-config at the rigt place since it
> is assuming cross compilation. let's force its value in the recipe.
>
> This patches 'fixes' library detection and brings the following diff:
>
> * RDEPENDS: ++libxcb (>= 1.12) libxcb-shape (>= 1.12) libxcb-shm (>= 1.12) libxcb-xfixes (>= 1.12)
> * PKGSIZE : 79167 -> 87823

I should have mentioned that we could do the following:

--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
@@ -87,6 +87,10 @@ EXTRA_OECONF = " \
     --enable-pic \
     --enable-shared \
     --enable-pthreads \
+    --disable-libxcb \
+    --disable-libxcb-shm \
+    --disable-libxcb-xfixes \
+    --disable-libxcb-shape \
     ${@bb.utils.contains('USE_NONFREE', 'yes', '--enable-nonfree', '', d)} \
     \

and it would make this patch a no-op instead. the patch would only
'fix' the pkg-config mistmatch. and we can fixup the xcb dependencies
as a follow up patch instead. i am opened to suggestions..

>
> Which basically means that the following conf options were left dangling in EXTRA_OECONF:
>
> --enable-libxcb
> --enable-libxcb-shm
> --enable-libxcb-xfixes
> --enable-libxcb-shape
>
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne at linaro.org>
> ---
>  meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
> index f4bb2ba1f5..442d4f4532 100644
> --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
> +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
> @@ -107,6 +107,7 @@ EXTRA_OECONF = " \
>      --datadir=${datadir}/ffmpeg \
>      ${@bb.utils.contains('AVAILTUNES', 'mips32r2', '', '--disable-mipsdsp --disable-mipsdspr2', d)} \
>      --cpu=${@cpu(d)} \
> +    --pkg-config=pkg-config \
>  "
>
>  EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
> --
> 2.11.0
>