[OE-core] [PATCH] ffmpeg: fix pkg-config utilization

[Nicolas Dechesne]

On Thu, Jul 20, 2017 at 2:54 PM, Khem Raj <raj.khem at gmail.com> wrote:
> On Thu, Jul 20, 2017 at 7:56 AM, Nicolas Dechesne
> <nicolas.dechesne at linaro.org> wrote:
>> in config.log we can see:
>> WARNING: aarch64-linaro-linux-pkg-config not found, library detection may fail.
>>
>> ffmpeg configure script is not looking for pkg-config at the rigt place since it
>> is assuming cross compilation. let's force its value in the recipe.
>>
>> This patches 'fixes' library detection and brings the following diff:
>>
>> * RDEPENDS: ++libxcb (>= 1.12) libxcb-shape (>= 1.12) libxcb-shm (>= 1.12) libxcb-xfixes (>= 1.12)
>> * PKGSIZE : 79167 -> 87823
>>
>> Which basically means that the following conf options were left dangling in EXTRA_OECONF:
>>
>> --enable-libxcb
>> --enable-libxcb-shm
>> --enable-libxcb-xfixes
>> --enable-libxcb-shape
>>
>> Signed-off-by: Nicolas Dechesne <nicolas.dechesne at linaro.org>
>> ---
>>  meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
>> index f4bb2ba1f5..442d4f4532 100644
>> --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
>> +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.3.2.bb
>> @@ -107,6 +107,7 @@ EXTRA_OECONF = " \
>>      --datadir=${datadir}/ffmpeg \
>>      ${@bb.utils.contains('AVAILTUNES', 'mips32r2', '', '--disable-mipsdsp --disable-mipsdspr2', d)} \
>>      --cpu=${@cpu(d)} \
>> +    --pkg-config=pkg-config \
>
> There is a proposal to repace pkgconfig with pkgconf, and I hope it

do you have a link?

> will create a symlink to provide pkg-config
> but it would be interesting to check, otherwise this fix will be
> voided with that change

what do you mean?

>
>>  "
>>
>>  EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
>> --
>> 2.11.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core