[OE-core] [PATCH V2] tclibc-musl.inc: fix bfd "cannot make copy relocation for protected symbol" issues

[Burton, Ross]

If we're going to silently change the linker to bfd under musl if
ld-is-gold is selected, wouldn't it be better just to throw an exception if
both musl and ld-is-gold are selected?  Better to tell the user so they can
not do that than silently ignore what they asked.

Ross

On 22 July 2017 at 14:30, <liu.ming50 at gmail.com> wrote:

> From: Ming Liu <peter.x.liu at external.atlascopco.com>
>
> Quite a few such compiling issues were found when I was building with
> following configs:
> ...
> MACHINE = "beaglebone"
> TCLIBC = "musl"
> DISTRO_FEATURES_append = " ld-is-gold"
> ...
>
> fixed by adding bfd binding now ldflags.
>
> Signed-off-by: Ming Liu <peter.x.liu at external.atlascopco.com>
> ---
>  meta/conf/distro/include/tclibc-musl.inc | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta/conf/distro/include/tclibc-musl.inc
> b/meta/conf/distro/include/tclibc-musl.inc
> index 3d3f6ac..99d52a1 100644
> --- a/meta/conf/distro/include/tclibc-musl.inc
> +++ b/meta/conf/distro/include/tclibc-musl.inc
> @@ -18,6 +18,10 @@ PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?=
> "nativesdk-glibc"
>
>  CXXFLAGS += "-fvisibility-inlines-hidden"
>
> +# Workaround for musl libc does not support bfd lazy binding well
> +# Refer to: https://bugzilla.yoctoproject.org/show_bug.cgi?id=11679
> +LDFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold',
> '-Wl,-z,relro,-z,now -fuse-ld=bfd', '', d)}"
> +
>  IMAGE_LINGUAS = ""
>
>  LIBC_DEPENDENCIES = "\
> --
> 2.7.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170724/46799bee/attachment-0002.html>