[OE-core] [PATCH v4 0/6] #11662 - wic should mount /boot

Ed Bartosh ed.bartosh at linux.intel.com
Thu Jul 27 14:02:41 UTC 2017


Hi,

This patchset adds /boot to the /etc/fstab of root partition, making
it mounted on boot. It also fixes reporting and testing issues
caused by this change.

The patchset also fixes long standing bug: wic updated fstab
inplace in rootfs directory. This causes other tasks working with
rootfs directory to produce incorrect results or crash. This is
fixed by copying rootfs content to the temporary directory before
updating fstab.

In previous versions of this patchset temporary rootfs directory
was created using copyhardlinktree API. This broke do_image_tar
as creating hardlinks changes file ctime and causes tar to exit
with the error "file changed as we read it". It's fixes in v4
by using copying instead of hardlinking. This is slower, but
it shouldn't influence overall build time too much as even for
a rootfs size 500Mb it takes only 1.5 sec

Changes in v2: squashed patches by reviewer's request
Changes in v3: unlink /etc/fstab in rootfs copy before updating it
Changes in v4: used 'cp -a' instead of copyhardlinktree to avoid
               do_image_tar failure due to changed ctime

The following changes since commit b73f5e088a543775a2a94b60302f750edfffbd10:

  wic-tools: add dependency to e2fsprogs-native (2017-07-27 16:07:26 +0300)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ed/wip
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wip

Ed Bartosh (6):
  wic: copy rootfs directory before changing fstab
  wic: use absolute paths in rootfs plugin
  wic: rootfs: fix rootfs path reporting
  wic: rootfs: make copied rootfs unique
  wic: add /boot mount point to fstab by default
  oe-selftest: wic: fix test_quemu

 meta/lib/oeqa/selftest/cases/wic.py      |  2 +-
 scripts/lib/wic/plugins/imager/direct.py | 24 ++++++++++++++----------
 scripts/lib/wic/plugins/source/rootfs.py | 16 +++++++---------
 3 files changed, 22 insertions(+), 20 deletions(-)

--
Regards,
Ed



More information about the Openembedded-core mailing list