[OE-core] [PATCH] psplash: Initialize psplash only if a framebuffer exists

[Mark Hatle]

On 9/6/17 8:31 AM, Mike Looijmans wrote:
> Isn't this a weird situation?
> 
> If you installed psplash but don't have a framebuffer, then something must be 
> broken. I'd rather see that error than this being silently ignored and then 
> wondering where the splash went.

Sorry I missed this reply before.

We choose to disable the warning because we've got many systems where we have a
common rootfs.  Some of them have displays and some do not.  The message was
triggering test failures (that look for errors/warning on bootup.)

It might make sense for someone to check and instead of silently stop, report
back a message that indicates that there is no framebuffer instead of the
existing error.  That would at least make this a 'known' condition.

> There's the corner case (most of my boards and for example settop boxes behave 
> like this) that the framebuffer initializes some time later in the boot 
> process (e.g. after loading FPGA logic, or loading some closed-source binary 
> video driver blob). For these systems, the psplash should be initialized by 
> the hotplug manager (mdev, udev, systemd) as soon as the device appears.

I hadn't considered that setup, but yes.  An extension to udev or similar would
make sense in that case.

--Mark

> On 05-09-17 04:10, Mark Hatle wrote:
>> psplash-init exits if there is no framebuffer device detected.
>> This is done to avoid the following error message from
>> occurring when booting up:
>>
>> "Error opening /dev/fb0: No such file or directory"
>>
>> Signed-off-by: Aws Ismail <aws.ismail at windriver.com>
>> Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
>> ---
>>   meta/recipes-core/psplash/files/psplash-init | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/meta/recipes-core/psplash/files/psplash-init b/meta/recipes-core/psplash/files/psplash-init
>> index 66c85e9..0bce1de 100755
>> --- a/meta/recipes-core/psplash/files/psplash-init
>> +++ b/meta/recipes-core/psplash/files/psplash-init
>> @@ -7,6 +7,12 @@
>>   # Default-Stop:
>>   ### END INIT INFO
>>   
>> +if [ ! -e /dev/fb0 ]; then
>> +    echo "Framebuffer /dev/fb0 not detected"
>> +    echo "Boot splashscreen disabled"
>> +    exit 0;
>> +fi
>> +
>>   read CMDLINE < /proc/cmdline
>>   for x in $CMDLINE; do
>>           case $x in
>>
> 
> 
> 
> Kind regards,
> 
> Mike Looijmans
> System Expert
> 
> TOPIC Products
> Materiaalweg 4, NL-5681 RJ Best
> Postbus 440, NL-5680 AK Best
> Telefoon: +31 (0) 499 33 69 79
> E-mail: mike.looijmans at topicproducts.com
> Website: www.topicproducts.com
> 
> Please consider the environment before printing this e-mail
> 
> 
>