[OE-core] [meta-oe][PATCH v3 2/2] libgcrypt: provide libgcrypt-config wrapper around pkg-config

[Alexander Kanavin]

On 09/15/2017 03:03 PM, Jussi Laako wrote:
> This patch adds a libgcrypt-config wrapper for pkg-config support in
> order to avoid patching all upstream packages using libgcrypt, while
> otherwise keeping pkg-config functionality.
> 
> Signed-off-by: Jussi Laako <jussi.laako at linux.intel.com>
> ---
>   .../libgcrypt/files/libgcrypt-config-wrapper.patch | 113 +++++++++++++++++++++
>   meta/recipes-support/libgcrypt/libgcrypt_1.8.1.bb  |   5 +-
>   2 files changed, 115 insertions(+), 3 deletions(-)
>   create mode 100644 meta/recipes-support/libgcrypt/files/libgcrypt-config-wrapper.patch
> 
> diff --git a/meta/recipes-support/libgcrypt/files/libgcrypt-config-wrapper.patch b/meta/recipes-support/libgcrypt/files/libgcrypt-config-wrapper.patch
> new file mode 100644
> index 0000000000..167706535b
> --- /dev/null
> +++ b/meta/recipes-support/libgcrypt/files/libgcrypt-config-wrapper.patch
> @@ -0,0 +1,113 @@
> +diff -ur libgcrypt-1.8.1.orig/src/libgcrypt-config.in libgcrypt-1.8.1.new/src/libgcrypt-config.in
> +--- libgcrypt-1.8.1.orig/src/libgcrypt-config.in	2013-03-15 21:25:38.000000000 +0200
> ++++ libgcrypt-1.8.1.new/src/libgcrypt-config.in	2017-09-15 13:56:20.368277151 +0300

Please don't add bare patches with no information. In addition to mssing 
signed-off-by and upstream-status (you should have gotten an automated 
check failure for those), you should also add a 'commit message' for the 
patch, so that anyone looking at it can quickly see what it's for 
without digging through commit history. You can simply copy-paste the 
message to the oe-core commit then.

It's most convenient to add recipe patches using 'devtool 
modify/update-recipe' - that will automate away the boring bits.

Alex