[OE-core] [PATCH] package_manager.py: Skip gpgcheck while using dnf on target

[Manjukumar Harthikote Matha]

Hi All,

> -----Original Message-----
> From: Manjukumar Matha [mailto:manjukumar.harthikote-matha at xilinx.com]
> Sent: Tuesday, April 03, 2018 1:35 PM
> To: openembedded-core at lists.openembedded.org
> Cc: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Subject: [OE-core][PATCH] package_manager.py: Skip gpgcheck while using dnf on
> target
> 
> By default, RPM_SIGN_PACKAGES is not defined. Add gpgcheck=0 to oe-remote-
> repo.repo file, otherwise dnf will complain during install operation on target
> 
> Note, RPM_SIGN_PACKAGES is set only when you inherit sign_rpm explicitly
> 
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha at xilinx.com>
> ---
>  meta/lib/oe/package_manager.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
> index e006dc6..9f22fb0 100644
> --- a/meta/lib/oe/package_manager.py
> +++ b/meta/lib/oe/package_manager.py
> @@ -674,7 +674,7 @@ class RpmPM(PackageManager):
>              gpg_opts += 'repo_gpgcheck=1\n'
>              gpg_opts += 'gpgkey=file://%s/pki/packagefeed-gpg/PACKAGEFEED-GPG-
> KEY-%s-%s\n' % (self.d.getVar('sysconfdir'), self.d.getVar('DISTRO'),
> self.d.getVar('DISTRO_CODENAME'))
> 
> -        if self.d.getVar('RPM_SIGN_PACKAGES') == '0':
> +        if self.d.getVar('RPM_SIGN_PACKAGES') != '1':
>              gpg_opts += 'gpgcheck=0\n'
> 
>          bb.utils.mkdirhier(oe.path.join(self.target_rootfs, "etc", "yum.repos.d"))
> --

Any feedback/concerns on this patch? 

Thanks,
Manju