[OE-core] [morty][PATCH] buildhistory: fix latest_srcrev in the common case

[Andre McCurdy]

On Wed, Apr 4, 2018 at 6:21 PM, akuster808 <akuster808 at gmail.com> wrote:
> On 04/04/2018 05:54 PM, Andre McCurdy wrote:
>> On Wed, Mar 14, 2018 at 4:52 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>>> On Tue, Feb 27, 2018 at 5:06 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>>>> From: Christopher Larson <chris_larson at mentor.com>
>>>>
>>>> buildhistory was writing srcrevs.values() as SRCREV when only one
>>>> srcrev/branch exists. This returns a view of the dictionary values in python
>>>> 3, and used to return a list in python 2, neither of which is an appropriate
>>>> value for SRCREV. It was resulting in latest_srcrev files like this:
>>>>
>>>>     # SRCREV = "346584bf6e38232be8773c24fd7dedcbd7b3d9ed"
>>>>     SRCREV = "dict_values(['346584bf6e38232be8773c24fd7dedcbd7b3d9ed'])"
>>>>
>>>> Which in turn would result in invalid output in buildhistory-collect-srcrevs.
>>>> Fix by calling `next(iter())` on the `.values()`
>>> Ping.
>> Ping again.
>>
>> This should be a very low risk backport fix for morty but if there are
>> any concerns then please let me know.
>
> its in
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=stable/morty-next&id=92e7030eaf4618160cac4ef37b95fc3b7b83f9bd
>
> morty has been on hold for the new host glib 2.27 and sdk issues. Those
> issues have been finally addressed and we finally got a clean build. The
> backlog hold should be lifted and things should be flowing again shortly.

OK, thanks!

I checked oe-core/morty-next and oe-core-contrib/stable/morty-next and
didn't see it there. I forgot to check poky-contrib/stable/morty-next
as well... :-)

If poky-contrib is the official pre-staging area before oe-core
morty-next, then perhaps you could remove the oe-core-contrib
stable/morty-next branch to avoid confusion?