[OE-core] [PATCH] package_deb.bbclass: report error during creation

[Jens Rehsack]

> Am 17.12.2018 um 18:11 schrieb Burton, Ross <ross.burton at intel.com>:
> 
> On Sat, 15 Dec 2018 at 12:59, Jens Rehsack <sno at netbsd.org> wrote:
>> +        try:
>> +            subprocess.check_output("PATH=\"%s\" dpkg-deb -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir),
>> +                                    stderr=subprocess.STDOUT,
> 
> So stderr is redirected to stdout.
> 
>> +        except subprocess.CalledProcessError as cpe:
>> +            bb.note("%s" % cpe)
>> +            bb.note("%s" % cpe.stdout)
>> +            bb.note("%s" % cpe.stderr)
> 
> So why display both?

Better safe than sorry :P

> Do this as one bb.error

Sure

> and you won't need to re-raise as it will fail.

So neither raise nor pass - just print?

> Ross


Cheers
--
Jens Rehsack - rehsack at gmail.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20181218/89c5badd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20181218/89c5badd/attachment.sig>