[OE-core] [PATCH] systemd: add RDEPENDS on util-linux-getopt

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: MacLeod, Randy
> Sent: Friday, January 12, 2018 04:16
> To: Huang, Jie (Jackie); openembedded-core at lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] systemd: add RDEPENDS on util-linux-getopt
> 
> On 2018-01-10 10:07 PM, jackie.huang at windriver.com wrote:
> > From: Jackie Huang <jackie.huang at windriver.com>
> >
> > 'getopt' is needed by systemd-sysv-install, or it fails with:
> > | kdump.service is not a native service, redirecting to systemd-sysv-install.
> > | Executing: /lib/systemd/systemd-sysv-install enable kdump
> > | /lib/systemd/systemd-sysv-install: line 15: getopt: command not found
> >
> > Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> > ---
> >   meta/recipes-core/systemd/systemd_234.bb | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/systemd/systemd_234.bb b/meta/recipes-
> core/systemd/systemd_234.bb
> > index 4132cdf40f..5a0e4c2247 100644
> > --- a/meta/recipes-core/systemd/systemd_234.bb
> > +++ b/meta/recipes-core/systemd/systemd_234.bb
> > @@ -521,7 +521,7 @@ FILES_${PN} = " ${base_bindir}/* \
> >
> >   FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> 1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
> >
> > -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})
> util-linux-agetty"
> > +RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})
> util-linux-agetty util-linux-getopt"
> 
> It would be nice to make the dependency conditional on systemd being
> configured to support sysvinit scripts.

The sysvinit script is always supported for now:

commit 9d298d1563b3fd5ad569f806cc296e13279e7cf6
Author: Khem Raj <raj.khem at gmail.com>
Date:   Sun Sep 6 15:25:41 2015 +0000

    systemd: Implement OE-Specific systemd-sysv-install

    Support for chkconfig (--enable-chkconfig) was removed in favour of
    calling an abstraction /lib/systemd/systemd-sysv-install. This
    needs to be implemented for OE.

    Signed-off-by: Khem Raj <raj.khem at gmail.com>
    Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

So I think the unconditional dependency is needed unless we change the
support for sysvinit to be optional as well.

Thanks,
Jackie
> 
> ../Randy
> 
> >   RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
> generator', '', 'systemd-serialgetty', d)}"
> >   RDEPENDS_${PN} += "volatile-binds update-rc.d"
> >
> >
> 
> 
> --
> # Randy MacLeod.  WR Linux
> # Wind River an Intel Company