[OE-core] [PATCH] glib-2.0: Re-add the gettext depend

[Alistair Francis]

On Thu, Jan 18, 2018 at 11:23 AM, Joshua Lock
<joshua.g.lock at linux.intel.com> wrote:
>
>
> On 18/01/18 19:12, Alistair Francis wrote:
>>
>> Commit "glib-2.0: rationalise build dependencies"
>> (8b0ca0cb54c91611213556bdb99316d5e7ac5b3b) broke mingw glib builds with
>> the following error:
>>
>> This patch fixes the issue by re-adding the gettext dependency.
>>
>> Signed-off-by: Alistair Francis <alistair.francis at xilinx.com>
>> ---
>>   meta/recipes-core/glib-2.0/glib.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-core/glib-2.0/glib.inc
>> b/meta/recipes-core/glib-2.0/glib.inc
>> index 354d95cfe3..e6997ae88f 100644
>> --- a/meta/recipes-core/glib-2.0/glib.inc
>> +++ b/meta/recipes-core/glib-2.0/glib.inc
>> @@ -24,6 +24,7 @@ DEPENDS = "glib-2.0-native \
>>              virtual/libiconv \
>>              libffi \
>>              zlib \
>> +           gettext \
>
>
> If this is only required for mingw we should add it in a mingw override,
> something like (untested):
>
> DEPENDS_mingw32 += "gettext"
>
> That way we:
> a) know that it's a mingw dependency (and to test that toolchain before
> removing)
> b) don't bloat the DEPENDS where gettext isn't a strict requirement.

That seems fine to me, the only issue I see is that previously this
wasn't just a mingw depend, so there could be other causes and mingw
is just what I test.

Alistair

>
>>              ${@bb.utils.contains('PTEST_ENABLED', '1', 'dbus', '', d)}"
>>     PACKAGES += "${PN}-codegen ${PN}-utils"
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core