[OE-core] [PATCH pseudo] ports/linux: wrap faccessat()

Seebs seebs at seebs.net
Thu Aug 1 16:17:01 UTC 2019


On Thu,  1 Aug 2019 18:02:06 +0200
Max Kellermann <max+openembedded at blarg.de> wrote:

> + * wrap_access(int dirfd, const char *path, int mode, int flags) {

This should probably say "faccessat". I know it's just a comment, but
I try to be consistent about these.

> +	rc = real___fxstatat64(_STAT_VER, dirfd, path, &buf, AT_SYMLINK_NOFOLLOW);

We should probably be using flags here, not AT_SYMLINK_NOFOLLOW.
Or possibly (flags & AT_SYMLINK_NOFOLLOW). Otherwise, we'll get the wrong
results if called with flags not including AT_SYMLINK_NOFOLLOW.

-s


More information about the Openembedded-core mailing list