[OE-core] [PATCH] pseudo: Upgrade to latest to fix openat() with a directory symlink
Jason Wessel
jason.wessel at windriver.com
Thu Aug 1 19:55:12 UTC 2019
Looks like the checksum license changed between the prior commit and now. So I'll send a v2, because we don't want to break the master branch of oe-core.
Cheers,
Jason.
On 8/1/19 12:55 PM, Jason Wessel wrote:
> While working with ostree disk generation in conjunction with wic, I
> found a problem with pseudo where it tried to resolve a symlink when
> it shouldn't, based on openat() flags. I narrowed down the problem to
> a simple c program to reproduce the issue:
>
> int main()
> {
> /* Tested with: gcc -Wall -o app app.c ; echo "no pseudo" ; ./app ; echo "pseudo"; pseudo ./app */
> system("rm -rf tdir tlink");
> system("mkdir tdir");
> system("ln -s tdir tlink");
> DIR *dir = opendir(".");
> int dfd = dirfd(dir);
>
> int target_dfd = openat (dfd, "tlink", O_RDONLY | O_NONBLOCK | O_DIRECTORY | O_CLOEXEC | O_NOFOLLOW);
> if (target_dfd == -1) {
> printf("This is right\n");
> } else {
> printf("This is broken\n");
> }
> return 0;
> }
>
> Many thanks to Peter Seebach for fixing the problem in the pseudo code
> to use the same logic which was already there for the
> AT_SYMLINK_NOFOLLOW.
>
> Signed-off-by: Jason Wessel <jason.wessel at windriver.com>
> ---
> meta/recipes-devtools/pseudo/pseudo_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
> index 51db84c4d4..3350c3fabd 100644
> --- a/meta/recipes-devtools/pseudo/pseudo_git.bb
> +++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
> @@ -8,7 +8,7 @@ SRC_URI = "git://git.yoctoproject.org/pseudo \
> file://toomanyfiles.patch \
> "
>
> -SRCREV = "3fa7c853e0bcd6fe23f7524c2a3c9e3af90901c3"
> +SRCREV = "097ca3e245200c4a4333964af59a106c42ff3bca"
> S = "${WORKDIR}/git"
> PV = "1.9.0+git${SRCPV}"
>
More information about the Openembedded-core
mailing list