[OE-core] [PATCH] sqlite3: Fix zlib determinism problem

[Khem Raj]

On Tue, Aug 6, 2019 at 2:04 PM Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
>
> On Tue, 2019-08-06 at 13:58 -0700, Khem Raj wrote:
> > On Tue, Aug 6, 2019 at 1:57 PM Richard Purdie
> > <richard.purdie at linuxfoundation.org> wrote:
> > > sqlite3-native in particular was finding zlib from the host if
> > > zlib-devel
> > > was installed. This could lead to races where pseudo-native may or
> > > may not
> > > fail to build.
> > >
> > > We don't need/use compressed page support with sqlite so disable
> > > the dependency
> > > (it doesn't have a configure option so use a autoconf cache
> > > variable).
> > >
> > > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> > > ---
> > >  meta/recipes-support/sqlite/sqlite3.inc | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/meta/recipes-support/sqlite/sqlite3.inc
> > > b/meta/recipes-support/sqlite/sqlite3.inc
> > > index daf3db5e9fb..2ad621503cd 100644
> > > --- a/meta/recipes-support/sqlite/sqlite3.inc
> > > +++ b/meta/recipes-support/sqlite/sqlite3.inc
> > > @@ -21,6 +21,10 @@ CVE_PRODUCT = "sqlite"
> > >
> > >  inherit autotools pkgconfig
> > >
> > > +# disable compressed page support as we don't need it
> > > +# we can see non-deterministic floating zlib dependencies
> > > otherwise
> > > +CACHED_CONFIGUREVARS += "ac_cv_search_deflate=no"
> > > +
> >
> > should this be done for native only ?
>
> Its currently disabled on the target since the dependency isn't in the
> sysroot and nobody has asked for it...
>
> I think Jason is working on a PACKAGECONFIG controlled version but its
> going to be uglier and I'm torn...
>

yeah disabling unconditionally seems the path of least resistance meanwhile.

> Cheers,
>
> Richard
>