[OE-core] [warrior][PATCH] bitbake.conf: add git-lfs to HOSTTOOLS_NONFATAL

[Martin Jansa]

NAK

Yes, the first part was merged in warrior and is correct.

But this second part isn't good (you don't want git-lfs to sometimes work
and sometimes fail) and that's why it was rejected for master and
_shouldn't_ be merged to warrior. If you have recipes which need git-lfs,
then add it to normal HOSTTOOLS in your builds to make sure it's always
present when needed.

On Thu, Aug 15, 2019 at 9:01 AM Saini, Naveen Kumar <
naveen.kumar.saini at intel.com> wrote:

> The corresponding first patch of this patch series already merged in
> Warrior
>
>
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/bitbake/lib?h=warrior&id=6e3a4d7926296380da23536c29af35d5702e02fb
>
> So this patch should also go in warrior.
>
>
> On 8/15/19 2:53 PM, Naveen Saini wrote:
> > This provides git large file storage (lfs) extension.
> >
> > Include git-lfs conditionally. If git-lfs is present on host and repo
> > has lfs pointers, then git-lfs will be used. If git-lfs is not present
> > on host, it will be ignored.
> >
> > [YOCTO #13198]
> >
> > (From OE-Core rev: 2968ad8514721ec06e67aaf3fd5ec7b247b3431d)
> >
> > Signed-off-by: Naveen Saini <naveen.kumar.saini at intel.com>
> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> > ---
> >   meta/conf/bitbake.conf | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index c996301a8b..c5313ccd19 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -514,6 +514,9 @@ HOSTTOOLS_NONFATAL += "bzr"
> >   # Used by ssh fetcher
> >   HOSTTOOLS_NONFATAL += "scp"
> >
> > +# Link to git-lfs if present
> > +HOSTTOOLS_NONFATAL += "git-lfs"
> > +
> >   CCACHE ??= ""
> >
> >   TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TARGET}"
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190815/94e807c8/attachment.html>