[OE-core] [PATCH 2/2] quilt: added less to RDEPENDS list

[Andre McCurdy]

On Wed, Aug 21, 2019 at 7:43 PM Randy MacLeod
<randy.macleod at windriver.com> wrote:
>
> Re: [OE-core] [PATCH 2/2] quilt: added less to RDEPENDS list
>
> s/added/add/
>
> When in Rome:
> $ cd .../oe-core
> $ git log --oneline -10000 | grep -i add | wc -l
> 1376
>
> $ git log --oneline -10000 | grep -i added | wc -l
> 19
>
> On 8/21/19 4:01 PM, Trevor Gamblin wrote:
> > From: Trevor Gamblin <trevor.gamblin at windriver.com>
> >
> > The quilt "series" option relies on "less -R", but > BusyBox's implementation of less does not provide -R. It
> > could be determined how to enable it in busybox's recipe,
> > but given the use case it likely isn't needed.
>
> That statement could be misleading, try:
>
> The quilt "series" option relies on "less -R" but since
> that option is not enabled by busybox in oe-core by default
> so hard-code the dependency on 'less'.

Still sounds awkward. Try:

  The quilt "series" option relies on "less -R" but, since that option
is not enabled by busybox in oe-core by default, hard-code the
dependency on 'less'.

Or:

  The quilt "series" option relies on "less -R". That option is not
enabled by busybox in oe-core by default so hard-code the dependency
on 'less'.

>  From 'man less':
>     -r or --raw-control-chars
>        Causes "raw" control characters to be displayed. ...
>     -R or --RAW-CONTROL-CHARS
>        Like -r, but only ANSI "color" escape sequences are
>        output in "raw" form.  ...
>
> In 2018, BusyBox's less added:
>     8528d3d4f less: optional support of -R
> but it is not enable by default for oe-core. While we could
> enable the option, all known use-cases involve larger, more
> developer-oriented recipes such as quilt or man pages.
>
> ---
>
> I maintain that we need to resist adding one more wafer-thin
> 200 byte config to our default busybox config to avoid bloat
> over the years. We wouldn't want the busybox package to burst!
>
> ../Randy
>
>  > could be determined how to enable it in busybox's recipe,
>  > but given the use case it likely isn't needed.
> >
> > Signed-off-by: Trevor Gamblin <trevor.gamblin at windriver.com>
> > ---
> >   meta/recipes-devtools/quilt/quilt.inc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/quilt/quilt.inc b/meta/recipes-devtools/quilt/quilt.inc
> > index dcba62c..433e9b4 100644
> > --- a/meta/recipes-devtools/quilt/quilt.inc
> > +++ b/meta/recipes-devtools/quilt/quilt.inc
> > @@ -78,7 +78,7 @@ FILES_guards = "${bindir}/guards"
> >   FILES_${PN}-doc = "${mandir}/man1/quilt.1 ${docdir}/${BPN}"
> >   FILES_guards-doc = "${mandir}/man1/guards.1"
> >
> > -RDEPENDS_${PN} = "bash patch diffstat bzip2 util-linux"
> > +RDEPENDS_${PN} = "bash patch diffstat bzip2 util-linux less"
> >   RDEPENDS_${PN}_class-native = "diffstat-native patch-native bzip2-native"
> >
> >   RDEPENDS_${PN}-ptest = "make file sed gawk diffutils findutils ed perl \
> >
>
>
> --
> # Randy MacLeod
> # Wind River Linux
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core