[OE-core] [PATCH] insane: improve license checksumming logic

[Andre McCurdy]

On Thu, Mar 21, 2019 at 5:30 AM Ross Burton <ross.burton at intel.com> wrote:
>
> Instead of opening files as bytes and battling decoding to UTF-8 which can throw
> exceptions, open directly as strings and replace invalid codepoints.  This
> handles licenses in encodings which are not UTF-8 but are based on ASCII much
> better.
>
> Also instead of extracting the license lines, writing them to a file, and then
> hashing the file, hash the lines directly.

This change seems to cause a regression in the debug output generated
if LIC_FILES_CHKSUM is wrong. If endline is set incorrectly to include
an empty line beyond the end of the intended license text then that
empty line will no longer be shown between the "vvv" and "^^^" lines
in the debug output... even though the extra line is included in the
md5 calculation.