[OE-core] [PATCH] bitbake.conf: Stop exporting TARGET_ flags variables

[richard.purdie at linuxfoundation.org]

On Mon, 2019-07-01 at 12:23 -0700, Andre McCurdy wrote:
> On Sun, Jun 30, 2019 at 3:00 PM Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
> > On Tue, 2019-06-25 at 14:16 +0100, Mike Crowe wrote:
> > > Way back in
> > > http://lists.openembedded.org/pipermail/openembedded-core/2014-April/210138.html
> > > a few of us discussed not exporting TARGET_LDFLAGS. There seemed
> > > to be
> > > support for this idea, and I modified our tree to not do so. I
> > > then seem to
> > > have dropped the ball. :( We've been running like that for over
> > > five years,
> > > and not observed any problems.
> > > 
> > > It seems sensible to stop exporting TARGET_CPPFLAGS,
> > > TARGET_CFLAGS and
> > > TARGET_CXXFLAGS too.
> > > 
> > > I've successfully compile-tested core-image-minimal and core-
> > > image-sato for
> > > x86_64 and qemuarm64 with these changes.
> > 
> > FWIW I'm really happy to see this!
> 
> Yes, good too see this. Does it mean we're also now ready to address
> (e.g. remove or poison?) these variables for -native and -nativesdk
> as well? Or is that still considered too risky?

Initially I thought you meant they were being exported and they're not.

There aren't many references to TARGET_CFLAGS in recipes, it wouldn't
be hard to clean up the remaining references (the cross recipe
references are needed and can stay), then we could look at deleting
them in those classes...

If we don't do it now it may be worth a bug so we remember.

Cheers,

Richard