[OE-core] [PATCH] bitbake: gitsm: download submodules

[Paul Barker]

On Wed, 4 Mar 2020 08:12:27 +0000
"Freihofer, Adrian" <adrian.freihofer at siemens.com> wrote:

> The unpack function failed because the submodules were not downloaded.
> Calling download before unpack for each submodule solves this issue.
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer at siemens.com>
> ---
>  bitbake/lib/bb/fetch2/gitsm.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/bitbake/lib/bb/fetch2/gitsm.py
> b/bitbake/lib/bb/fetch2/gitsm.py
> index c622771d21..3715e9824f 100644
> --- a/bitbake/lib/bb/fetch2/gitsm.py
> +++ b/bitbake/lib/bb/fetch2/gitsm.py
> @@ -184,6 +184,7 @@ class GitSM(Git):
>  
>              try:
>                  newfetch = Fetch([url], d, cache=False)
> +                newfetch.download()
>                  newfetch.unpack(root=os.path.dirname(os.path.join(repo
> _conf, 'modules', module)))
>              except Exception as e:
>                  logger.error('gitsm: submodule unpack failed: %s %s' %
> (type(e).__name__, str(e)))

You shouldn't be trying to download submodules in the do_unpack step. If
they're missing at this stage it probably indicates a fetch issue.

What's the exact error that you're seeing?

This could be related to the issue I saw when the fetcher uses git shallow
tarballs from a mirror - if that's the case I'm planning to get that fixed
this weekend.

Also, your email client seems to have chewed the patch up. It's best to send
patches using `git send-email` only.

-- 
Paul Barker
Konsulko Group