[OE-core] [PATCH] gdbm: add depend on readline for consistent builds

[Jeremy A. Puhlman]

On 3/4/2020 4:03 PM, Andre McCurdy wrote:
> On Wed, Mar 4, 2020 at 3:48 PM Jeremy A. Puhlman <jpuhlman at mvista.com> wrote:
>> On 3/4/2020 3:43 PM, Andre McCurdy wrote:
>>> On Wed, Mar 4, 2020 at 3:22 PM Khem Raj <raj.khem at gmail.com> wrote:
>>>> On Wed, Mar 4, 2020 at 2:25 PM Jeremy A. Puhlman <jpuhlman at mvista.com> wrote:
>>>>> From: Jeremy Puhlman <jpuhlman at mvista.com>
>>>>>
>>>>> Whether readline is installed on the build host or not
>>>>> influences the way gdbm builds. Depend on readline for
>>>>> a consistent build.
>>> It sounds like configuring with --without-readline would be a better solution?
>> Its an either/or. I suggested both in the bug(13714) basically either works.
> If both approaches work then an explicit configure option is preferred.

Alternate patch sent.


>
>>>>> This fails to build on a system with readline, and using
>>>>> the buildtools-extended installer.
>>>>>
>>>>> Signed-off-by: Jeremy A. Puhlman <jpuhlman at mvista.com>
>>>>> ---
>>>>>    meta/recipes-support/gdbm/gdbm_1.18.1.bb | 2 ++
>>>>>    1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/meta/recipes-support/gdbm/gdbm_1.18.1.bb b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
>>>>> index 7e2efe3c9b..5326184181 100644
>>>>> --- a/meta/recipes-support/gdbm/gdbm_1.18.1.bb
>>>>> +++ b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
>>>>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "86e613527e5dba544e73208f42b78b7c022d4fa5a6d5498bf18c8d6f74
>>>>>
>>>>>    inherit autotools gettext texinfo lib_package ptest
>>>>>
>>>>> +DEPENDS_class-native += "readline"
>>> Don't use += with an over-ride. It doesn't do what you might expect.
>> Okay.
>>
>> --
>> Jeremy A. Puhlman
>> jpuhlman at mvista.com
>>

-- 
Jeremy A. Puhlman
jpuhlman at mvista.com