[OE-core] [PATCH] bison: Reset load average settings if specified in environment

[Alexander Kanavin]

Shouldn’t the race be fixed? This might still happen because -j still
parallelises the build,no?

Alex

On Sun 15. Mar 2020 at 5.30, Khem Raj <raj.khem at gmail.com> wrote:

> In some cases, we run into parallel build failures where BUILT_SOURCES
> is skipped, as a result required header files are not generated and the
> build fails with missing header errors like
>
> ../bison-3.5.2/lib/uniwidth/width.c:21:10: fatal error: uniwidth.h: No
> such file or directory
>  #include "uniwidth.h"
>           ^~~~~~~~~~~~
> compilation terminated.
>
> BUILT_SOURCES should be built automatically with `make all` [1] therefore
> ensure that make is invoked with `all` target
>
> bison-native parallel build fails when -l<n> is passed globally from
> build environment, errors like below due to race starts to show up
>
> Therefore removes a previous load limit if set
>
> [1]
> https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html#Built-Sources-Example
>
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta/recipes-devtools/bison/bison_3.5.3.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta/recipes-devtools/bison/bison_3.5.3.bb
> b/meta/recipes-devtools/bison/bison_3.5.3.bb
> index 09e4b18f9e..27e09434f8 100644
> --- a/meta/recipes-devtools/bison/bison_3.5.3.bb
> +++ b/meta/recipes-devtools/bison/bison_3.5.3.bb
> @@ -18,6 +18,12 @@ SRC_URI[sha256sum] =
> "2bf85b5f88a5f2fa8069aed2a2dfc3a9f8d15a97e59c713e3906e5fdd9
>  # No point in hardcoding path to m4, just use PATH
>  EXTRA_OECONF += "M4=m4"
>
> +# Reset any loadavg set via environment, it breaks parallel build
> +# | ../bison-3.5.2/lib/uniwidth/width.c:21:10: fatal error: uniwidth.h:
> No such file or directory
> +# |  #include "uniwidth.h"
> +# |           ^~~~~~~~~~~~
> +EXTRA_OEMAKE_append = " -l"
> +
>  inherit autotools gettext texinfo
>
>  # The automatic m4 path detection gets confused, so force the right value
> --
> 2.25.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20200315/5de80892/attachment.html>