[OE-core] [zeus][PATCH] sanity: check for more bits of Python

[Andre McCurdy]

On Thu, Mar 19, 2020 at 12:19 PM Martin Jansa <martin.jansa at gmail.com> wrote:
>
> From: Ross Burton <ross.burton at intel.com>
>
> MJ: icu in master doesn't need distutils anymore, because icu 65.1 currently in
> dunfell/master doesn't depend on python3-distutils anymore since:
> https://github.com/unicode-org/icu/commit/b4d41b0561b6e8de38b99850ce0e4be8ef536bb1
>
> but the icu-64.2 in zeus and openembedded-core/meta/recipes-core/ovmf/ovmf_git.bb
> still need python3-distutils as described in:
> http://lists.openembedded.org/pipermail/openembedded-core/2020-March/293984.html
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/classes/sanity.bbclass | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 936fe913b4..5c2f8f9d75 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -625,13 +625,14 @@ def check_sanity_version_change(status, d):
>      # In other words, these tests run once in a given build directory and then
>      # never again until the sanity version or host distrubution id/version changes.

s/distrubution/distribution/ (not part of the original patch but maybe
worth fixing in a v2).

> -    # Check the python install is complete. glib-2.0-natives requries
> -    # xml.parsers.expat
> +    # Check the python install is complete. Examples that are often removed in
> +    # minimal installations: glib-2.0-natives requries # xml.parsers.expat and icu

Stray # left over from reformatting the comment.

> +    # requires distutils.sysconfig.
>      try:
>          import xml.parsers.expat
> -    except ImportError:
> -        status.addresult('Your python is not a full install. Please install the module xml.parsers.expat (python-xml on openSUSE and SUSE Linux).\n')
> -    import stat
> +        import distutils.sysconfig
> +    except ImportError as e:
> +        status.addresult('Your Python 3 is not a full install. Please install the module %s (see the Getting Started guide for further information).\n' % e.name)

Should that be the Yocto Project Quick Start? Googling for "yocto
getting started guide" doesn't come up with anything.

The version of Yocto Project Quick Start found by google doesn't
mention anything about installing python3-distutils though, so maybe
it's not the right document...

>      status.addresult(check_make_version(d))
>      status.addresult(check_patch_version(d))
> @@ -667,6 +668,7 @@ def check_sanity_version_change(status, d):
>          status.addresult('Please use ASSUME_PROVIDED +=, not ASSUME_PROVIDED = in your local.conf\n')
>
>      # Check that TMPDIR isn't on a filesystem with limited filename length (eg. eCryptFS)
> +    import stat
>      tmpdir = d.getVar('TMPDIR')
>      status.addresult(check_create_long_filename(tmpdir, "TMPDIR"))
>      tmpdirmode = os.stat(tmpdir).st_mode
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core