[oe] [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES

[Marcin Juszkiewicz]

Dnia poniedziałek, 7 lutego 2011 o 23:13:42 Filip Zyzniewski napisał(a):
> This reduces amount of tasks for bootstrap-image from around 3400 to
> around 1600 for jlime.
> 
> Signed-off-by: Filip Zyzniewski <filip.zyzniewski at gmail.com>
> ---
>  recipes/tasks/task-base.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
> index 32d871d..c8d6df7 100644
> --- a/recipes/tasks/task-base.bb
> +++ b/recipes/tasks/task-base.bb
> @@ -1,5 +1,5 @@
>  DESCRIPTION = "Merge machine and distro options to create a basic machine
> task/package" -PR = "r92"
> +PR = "r93"
> 
>  inherit task
> 
> @@ -31,8 +31,8 @@ PACKAGES = ' \
>              ${@base_contains("MACHINE_FEATURES", "redboot",
> "task-base-redboot", "",d)} \ ${@base_contains("MACHINE_FEATURES", "apex",
> "task-base-apex", "",d)} \ \
> -            task-base-bluetooth \
> -            task-base-wifi \
> +            ${@base_contains("MACHINE_FEATURES", "bluetooth",
> "task-base-bluetooth", "",d)} \ +           
> ${@base_contains("MACHINE_FEATURES", "wifi", "task-base-wifi", "",d)} \ \
>              ${@base_contains("DISTRO_FEATURES", "cramfs",
> "task-base-cramfs", "", d)} \ ${@base_contains("DISTRO_FEATURES", "ipsec",
> "task-base-ipsec", "", d)} \

This change is bogus. You just remove building of BT/Wifi support for "bitbake 
bootstrap-image" for your machine not distro. Use DISTRO_FEATURES instead and 
then remove "bluetooth wifi" from DISTRO_FEATURES in your distribution config 
file.

Other way is to create own copy of task-base and boostrap-image recipes. 
Easiest way would to have jlime overlay with recipes/task-base-jlime.bb which 
would "require task-base.bb" + "PROVIDES = task-base" + define own PACKAGES 
variable - this will give you everything from task-base defined + your change 
above. You only need to select it in your distro config as preferred provider 
of task-base.

task-base was created several years ago as attempt to get something better 
then task-bootstrap which we used before. BT/Wifi part was done to have 
support for cf/usb/pci connected dongles/cards. And it worked fine but was not 
perfect. 

Regards, 
-- 
JID:      hrw at jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz