[oe] [PATCH] insane.bbclass: Make RPATH a non-fatal error

[Khem Raj]

On (18/02/11 12:26), Tom Rini wrote:
> In order to make the user experience better we now use bb.warn
> on non-fatal QA errors and bb.error on fatal errors.
> 
> Signed-off-by: Tom Rini <tom_rini at mentor.com>

I really would like to get these issues fixed but I guess from grand
scheme of things for now

Acked-by: Khem Raj <raj.khem at gmail.com>

> ---
>  classes/insane.bbclass |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/classes/insane.bbclass b/classes/insane.bbclass
> index a846832..3b042c9 100644
> --- a/classes/insane.bbclass
> +++ b/classes/insane.bbclass
> @@ -116,7 +116,7 @@ def package_qa_make_fatal_error(error_class, name, path,d):
>  
>      TODO: Load a whitelist of known errors
>      """
> -    return not error_class in [0, 5, 7]
> +    return not error_class in [0, 1, 5, 7]
>  
>  def package_qa_write_error(error_class, name, path, d):
>      """
> @@ -145,10 +145,16 @@ def package_qa_write_error(error_class, name, path, d):
>               (ERROR_NAMES[error_class], name, package_qa_clean_path(path,d))
>      f.close()
>  
> +# Returns False is there was a fatal problem and True if we did not hit a fatal
> +# error
>  def package_qa_handle_error(error_class, error_msg, name, path, d):
> -    bb.error("QA Issue with %s: %s" % (name, error_msg))
> +    fatal = package_qa_make_fatal_error(error_class, name, path, d)
>      package_qa_write_error(error_class, name, path, d)
> -    return not package_qa_make_fatal_error(error_class, name, path, d)
> +    if fatal:
> +        bb.error("QA Issue with %s: %s" % (name, error_msg))
> +    else:
> +        bb.warn("QA Issue with %s: %s" % (name, error_msg))
> +    return not fatal
>  
>  def package_qa_check_rpath(file,name,d, elf):
>      """
> -- 
> 1.7.3.5
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
-Khem