[oe] [meta-networking][PATCH] networkmanager: fix "installed-vs-shipped" QA issue

[Mark Asselstine]

On Friday, May 4, 2018 12:02:25 PM EDT Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-devel-bounces at lists.openembedded.org
> > [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> > Mark Asselstine
> > Sent: den 3 maj 2018 20:12
> > To: openembedded-devel at lists.openembedded.org
> > Subject: [oe] [meta-networking][PATCH] networkmanager: fix "installed-
> > vs-shipped" QA issue
> > 
> > When building we can see the following QA issue:
> >   QA Issue: networkmanager: Files/directories were installed but
> >   
> >     not shipped in any package:
> >   [2018-05-02 23:01:40.442528079-07:00]   /usr/lib/NetworkManager
> >   [2018-05-02 23:01:40.450990449-07:00]
> > 
> > /usr/lib/NetworkManager/conf.d
> > 
> >   [2018-05-02 23:01:40.456642738-07:00]   /usr/lib/NetworkManager/VPN
> > 
> > The upstream project moved these to $prefix/lib as part of upstream
> > commit 74818b155c32 [build: fix $nmlibdir to be
> > "/usr/lib/NetworkManager"] and here we adapt the recipe to take this
> > change into effect.
> > 
> > Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>
> > ---
> > 
> >  .../recipes-connectivity/networkmanager/networkmanager_1.10.6.bb
> >  
> > | 4 ++--
> >  
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-networking/recipes-
> > connectivity/networkmanager/networkmanager_1.10.6.bb b/meta-
> > networking/recipes-connectivity/networkmanager/networkmanager_1.10.6.bb
> > index d90b782..91636ec 100644
> > --- a/meta-networking/recipes-
> > connectivity/networkmanager/networkmanager_1.10.6.bb
> > +++ b/meta-networking/recipes-
> > connectivity/networkmanager/networkmanager_1.10.6.bb
> > @@ -100,8 +100,8 @@ FILES_${PN} += " \
> > 
> >      ${libexecdir} \
> >      ${libdir}/pppd/*/nm-pppd-plugin.so \
> >      ${libdir}/NetworkManager/*.so \
> > 
> > -    ${libdir}/NetworkManager/VPN \
> > -    ${libdir}/NetworkManager/conf.d \
> > +    ${prefix}/lib/NetworkManager/VPN \
> > +    ${prefix}/lib/NetworkManager/conf.d \
> 
> There is a variable for ${prefix}/lib: nonarch_libdir, i.e.:
> 
>     ${nonarch_libdir}/NetworkManager/VPN \
>     ${nonarch_libdir}/NetworkManager/conf.d \

I opted to use ${prefix}/lib as I liked how it matched upstream's syntax in 
configure.ac, making searching a bit more logical. But I am not fuss and will 
send a V2 with this change.

MarkA

> 
> >      ${datadir}/polkit-1 \
> >      ${datadir}/dbus-1 \
> >      ${base_libdir}/udev/* \
> > 
> > --
> > 2.7.4
> 
> //Peter