[oe] [meta-multimedia][PATCH v2 1/2] openh264: fix build for 32-bit intel arch

[Khem Raj]

On Wed, May 16, 2018 at 10:06 AM, Trevor Woerner <twoerner at gmail.com> wrote:
> Signed-off-by: Trevor Woerner <twoerner at gmail.com>
> ---
>  .../recipes-multimedia/openh264/openh264_1.7.0.bb        | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb b/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
> index a7aaab3623..d77de2876b 100644
> --- a/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
> +++ b/meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb
> @@ -3,9 +3,8 @@ decoding. It is suitable for use in real time applications such as WebRTC."
>  HOMEPAGE = "http://www.openh264.org/"
>  SECTION = "libs/multimedia"
>
> -DEPENDS = "${@oe.utils.conditional('TARGET_ARCH', 'i386', 'nasm-native', \
> -              oe.utils.conditional('TARGET_ARCH', 'x86_64', 'nasm-native', \
> -             '', d), d)}"
> +DEPENDS_x86 += "nasm-native"
> +DEPENDS_x86-64 += "nasm-native"
>

if using overrides, perhaps using _append instead of += is better.

>  LICENSE = "BSD-2-Clause"
>  LICENSE_FLAGS = "commercial"
> @@ -17,14 +16,14 @@ SRC_URI[sha256sum] = "9c07c38d7de00046c9c52b12c76a2af7648b70d05bd5460c8b67f68957
>
>  COMPATIBLE_MACHINE_armv7a = "(.*)"
>  COMPATIBLE_MACHINE_aarch64 = "(.*)"
> -COMPATIBLE_MACHINE_i386 = "(.*)"
> +COMPATIBLE_MACHINE_x86 = "(.*)"
>  COMPATIBLE_MACHINE_x86-64 = "(.*)"
>  COMPATIBLE_MACHINE_mips = "(.*)"
>  COMPATIBLE_MACHINE_mips64 = "(.*)"
>
>  EXTRA_OEMAKE_armv7a = "ARCH=arm"
>  EXTRA_OEMAKE_aarch64 = "ARCH=arm64"
> -EXTRA_OEMAKE_i386 = "ARCH=i386"
> +EXTRA_OEMAKE_x86 = "ARCH=i386"

can you take another look if there are other options eg. i686 ?
if in literal sense it means i386 then we should not be using it
for newer i*86 arches.

>  EXTRA_OEMAKE_x86-64 = "ARCH=x86_64"
>  EXTRA_OEMAKE_mips = "ARCH=mips"
>  EXTRA_OEMAKE_mips64 = "ARCH=mips64"
> --
> 2.17.0.rc2.3.gc2a499e6c
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel