[oe] [meta-oe][PATCH 5/8] luajit: Dont use BUILD_LDFLAGS when compiling host binaries

[Khem Raj]

Hi Carlos

Thanks for your review

On 5/17/18 9:38 PM, Carlos Alberto Lopez Perez wrote:
> On 12/05/18 05:07, Khem Raj wrote:
>> BUILD_LDFLAGS add --dynamic-linker to point to uninative but
>> some binaries in luajit are for 32bit build host, so even if
>> your host has the needed runtime, it will fail to execute because
>> uninative ldso doesn't know about multilib
>>
>> we get cyptic errors like
>>
>> | make[1]: execvp: host/minilua: Accessing a corrupted shared library
>> | make[1]: *** [Makefile:610: host/buildvm_arch.h] Error 127
>>
>> Switch to using git for SRC_URI, master is pointing to latest
>> 2.0 stable, it gets us all the patches done since last 2.0.5 relases
>> in 2017
>>
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> ---
>>   meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
> 
> I think HOST_LDFLAGS should remain for the native class.
> 
> Otherwise building luajit-native might fail.
> 
> I suggest adding something like this:
> 
> EXTRA_OEMAKE_remove_class-target = "'HOST_LDFLAGS=${BUILD_LDFLAGS}'"
> 

This would be a general case where we have bbclassextend for native
luajit is a special case however, where the needed build time tools
are built along the target build, thats why this fix.  The change you
you proposed might not work in this case.